REF: refactor ArrowExtensionArray._reduce #52890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 24, 2023
pandas/core/arrays/arrow/array.py
Outdated
| @@ -1223,9 +1223,9 @@ def _accumulate( | |||
|
|
|||
| return type(self)(result) | |||
|
|
|||
| def _reduce(self, name: str, *, skipna: bool = True, **kwargs): | |||
| def _reduce_pyarrow(self, name: str, *, skipna: bool = True, **kwargs): | |||
There was a problem hiding this comment.
Can we type this out at -> pa.Scalar?
There was a problem hiding this comment.
Yeah, it's possible. I've updated.
mroeschke
added
Refactor
1 task
mroeschke
approved these changes
Apr 25, 2023
|
Thanks @topper-123 |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* REF: refactor ArrowExtensionArray._reduce * fix * add return type to _reduce_pyarrow
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* REF: refactor ArrowExtensionArray._reduce * fix * add return type to _reduce_pyarrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
ArrowExtensionArray._reduce_pyarrowmethod that returns a pyarrow scalar and makesArrowExtensionArray._reduceget its pyarrow scalar from that and converts it there to a python scalar.There are situations where we want to know the type of the value returned from pyarrow reductions (e.g. #52788) and this allows us to get the pyarrow type.
This changes no functionality.